Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(enhanced): support shared module layers #3276

Open
wants to merge 55 commits into
base: main
Choose a base branch
from

Conversation

ScriptedAlchemy
Copy link
Member

@ScriptedAlchemy ScriptedAlchemy commented Nov 25, 2024

Description

This pull request enhances the module sharing functionality in the enhanced package by implementing comprehensive layer support and improving schema validation. The changes focus on the compiler mechanics for module layers, with runtime updates planned for a future PR.

Key Changes

  1. Schema Validation Enhancements

    • Added TypeScript-based validation for ConsumeSharedPlugin schema
    • Enhanced ProvideSharedPlugin schema with layer support
    • Added new properties for layer configuration:
      layer: {
        description: 'Layer for the shared module.',
        type: 'string',
        minLength: 1
      },
      issuerLayer: {
        description: 'Layer in which the issuer should be.',
        type: 'string',
        minLength: 1
      }
  2. Module Resolution Improvements

    • Enhanced request key creation with layer support
    • Updated module resolution logic to handle layer-specific requests
    • Improved handling of relative, absolute, and module requests
    • Added support for composite keys in module resolution
  3. Share Configuration Updates

    • Added layer support to normalizeConsumeShareOptions
    • Enhanced share scope management with layer awareness
    • Updated module matching logic to consider layer context
    • Improved type definitions for shared module configurations

Example Configuration

new SharePlugin({
  shareScope: 'default',
  shared: {
    react: {
      singleton: true,
    },
    'explicit-layer-react': {
      request: 'react/index2',
      import: 'react/index2',
      shareKey: 'react',
      singleton: true,
      issuerLayer: 'differing-layer',
      layer: 'explicit-layer',
    }
  }
})

Technical Implementation Details

  • [utils.ts]: Enhanced module resolution with layer support
  • [ConsumeSharedPlugin.check.ts]: Added comprehensive schema validation
  • [ProviderSharedPlugin.ts]: Updated schema with layer properties
  • Added support for composite keys in module resolution
  • Improved error handling for module resolution failures

Note

This PR focuses on the compiler mechanics for module layers. Runtime module aspects will be updated in a subsequent PR.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have updated the documentation

Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: ffdaf0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@module-federation/enhanced Major
@module-federation/modern-js Major
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/rsbuild-plugin Major
@module-federation/storybook-addon Patch
@module-federation/modernjsapp Patch
@module-federation/runtime Major
@module-federation/rspack Major
@module-federation/webpack-bundler-runtime Major
@module-federation/sdk Major
@module-federation/runtime-tools Major
@module-federation/managers Major
@module-federation/manifest Major
@module-federation/dts-plugin Major
@module-federation/third-party-dts-extractor Major
@module-federation/devtools Major
@module-federation/bridge-react Major
@module-federation/bridge-vue3 Major
@module-federation/bridge-shared Major
@module-federation/bridge-react-webpack-plugin Major
@module-federation/retry-plugin Major
@module-federation/data-prefetch Major
@module-federation/error-codes Major
@module-federation/esbuild Patch
@module-federation/utilities Patch
website-new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 10f2b73
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/6777609547b1ad0008b5b124
😎 Deploy Preview https://deploy-preview-3276--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@squadronai squadronai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Here is a concise summary of the changes in the pull request:

The key changes focus on enhancing the module sharing functionality in the enhanced package by introducing support for module layers. This includes:

  • Updating the ConsumeSharedModule and ConsumeSharedPlugin classes to handle layer-specific requests and module factorization, introducing new properties like layer, issuerLayer, and requiredLayer.
  • Enhancing the ConsumeSharedPlugin class to manage layer-specific configurations and provide better support for layer-based module sharing.
  • Adding a new Jest command to the package.json file to run specific test cases for module layer support.
  • Implementing TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new layer-related properties.

These changes aim to improve the module sharing capabilities in the enhanced package by providing more flexibility and control over how modules are consumed and shared, particularly in the context of layered module architectures.

File Summaries
File Summary
packages/enhanced/src/declarations/plugins/sharing/ConsumeSharedModule.d.ts Here is a short and concise technical summary of the changes:

The code changes introduce support for module layers in the ConsumeSharedModule and ConsumeSharedPlugin classes. This includes adding new properties (layer, issuerLayer, requiredLayer) to the ConsumeOptions type to specify and resolve module layers. Additionally, the ConsumeSharedPlugin class was updated to handle layer-specific requests and factorize modules based on the layer context. The changes also include updates to the package.json file, such as adding a new Jest command and updating the webpack-cli dependency, as well as adding TypeScript-based validation functions for the ConsumeSharedPlugin schema. |
| packages/enhanced/src/declarations/plugins/sharing/ConsumeSharedPlugin.d.ts | The changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  1. The ConsumeSharedModule and ConsumeSharedPlugin classes were updated to support module layers, allowing for more granular control over how modules are shared and consumed. New properties like layer, issuerLayer, and requiredLayer were added to the ConsumeOptions type and the plugin options.

  2. The ConsumeSharedPlugin class was updated to handle layer-specific requests and factorize modules based on the layer context, improving the overall module sharing capabilities.

  3. The package.json file was updated to add a new Jest command for testing the ConfigTestCases.basictest.js file, and the webpack-cli dependency was updated to version ^5.1.4.

  4. TypeScript-based validation functions were added to the ConsumeSharedPlugin.check.ts file to ensure proper validation of the new properties introduced for module layer support. |
    | packages/enhanced/src/declarations/plugins/sharing/ProvideSharedPlugin.d.ts | The key changes in this pull request are focused on enhancing the module sharing functionality in the enhanced package. The main highlights are:

  5. Added support for specifying and resolving module layers in the ConsumeSharedModule and ConsumeSharedPlugin classes. This includes introducing new properties like layer, issuerLayer, and requiredLayer to handle layer-specific requests and module factorization.

  6. Updated the ConsumeSharedPlugin class to manage layer-specific configurations and provide better support for layer-based module sharing.

  7. Added a new Jest command to the package.json file to run specific test cases for the ConfigTestCases.basictest.js file.

  8. Implemented TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new layer-related properties.

Overall, these changes aim to enhance the module sharing capabilities in the enhanced package by introducing support for module layers, which is a key requirement for managing complex module dependencies and sharing scenarios. |
| packages/enhanced/src/declarations/plugins/sharing/SharePlugin.d.ts | The code changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  1. The ConsumeSharedModule and ConsumeSharedPlugin classes have been updated to support module layers, allowing for more granular control over module resolution and sharing. New properties like layer, issuerLayer, and requiredLayer have been added to handle layer-specific requests and module factorization.

  2. The package.json file has been updated to include a new Jest command for running a specific test case, and the webpack-cli dependency has been updated to version ^5.1.4.

  3. TypeScript-based validation functions have been added to the ConsumeSharedPlugin schema to ensure proper validation of the new layer-related properties.

These changes aim to improve the module sharing capabilities in the enhanced package, providing more flexibility and control over how modules are consumed and shared across different layers or contexts. |
| packages/enhanced/src/lib/sharing/ConsumeSharedModule.ts | The code changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  1. Updates to the ConsumeSharedModule and ConsumeSharedPlugin classes to support module layers, including the addition of new properties like layer, issuerLayer, and requiredLayer to handle layer-specific requests and module factorization.
  2. Addition of a new Jest command in the package.json file to run a specific test case for the ConfigTestCases.basictest.js file.
  3. Updates to the schema validation for the ConsumeSharedPlugin to ensure proper validation of the new layer-related properties.

These changes aim to improve the module sharing capabilities by introducing support for module layers, which allows for more granular control and management of shared modules within the application. |
| packages/enhanced/src/lib/sharing/ConsumeSharedPlugin.ts | The code changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  1. The ConsumeSharedModule and ConsumeSharedPlugin classes have been updated to support module layers, allowing for more granular control over how modules are shared and consumed. This includes adding new properties like layer, issuerLayer, and requiredLayer to the ConsumeOptions type and updating the corresponding logic in the plugin.

  2. The package.json file has been updated to add a new Jest command for testing the ConfigTestCases.basictest.js file, and the webpack-cli dependency has been updated to version ^5.1.4.

  3. The schema validation for the ConsumeSharedPlugin has been improved by adding TypeScript-based validation functions to ensure proper validation of the new layer-related properties.

Overall, these changes aim to enhance the module sharing capabilities of the enhanced package, particularly by introducing support for module layers, which can help with more complex module management and sharing scenarios. |
| packages/enhanced/src/lib/sharing/ProvideSharedDependency.ts | The code changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  1. The ConsumeSharedModule and ConsumeSharedPlugin classes were updated to support module layers, allowing for more granular control over how modules are consumed and shared. This includes adding new properties like layer, issuerLayer, and requiredLayer to handle layer-specific requests and module factorization.

  2. The ProvideSharedDependency class was updated to include a new layer property, which allows for specifying layer information when providing shared modules.

  3. The package.json file was updated to add a new Jest command for testing the ConfigTestCases.basictest.js file, and the webpack-cli dependency was updated to version ^5.1.4.

  4. TypeScript-based validation functions were added to the ConsumeSharedPlugin schema to ensure proper validation of the new layer-related properties.

Overall, these changes aim to enhance the module sharing capabilities in the enhanced package, particularly by introducing support for module layers and improving the related configuration and validation mechanisms. |
| packages/enhanced/src/lib/sharing/ProvideSharedModule.ts | The code changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  1. Updated the ConsumeSharedModule and ConsumeSharedPlugin classes to support module layers, allowing for more granular control over module consumption and sharing. This includes adding new properties like layer, issuerLayer, and requiredLayer to handle layer-specific requests and module factorization.

  2. Added a new Jest command to the package.json file to run a specific test case for the ConfigTestCases.basictest.js file, and updated the webpack-cli dependency to version ^5.1.4.

  3. Implemented TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new layer-related properties.

The overall purpose of these changes is to enhance the module sharing capabilities in the enhanced package, allowing for more flexible and granular control over module consumption and sharing, particularly in the context of module layers. |
| packages/enhanced/src/lib/sharing/ProvideSharedModuleFactory.ts | The code changes introduce several enhancements and fixes to the module sharing functionality in the enhanced package. The key modifications include:

  1. Adding support for specifying and resolving module layers in the ConsumeSharedModule and ConsumeSharedPlugin classes. This includes introducing new properties like layer, issuerLayer, and requiredLayer to handle layer-specific requests and factorize modules based on the layer context.

  2. Updating the package.json file to add a new Jest command for running a specific test case and updating the webpack-cli dependency to version ^5.1.4.

  3. Implementing TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new layer-related properties.

The changes aim to enhance the module sharing functionality by introducing support for module layers, which allows for more granular control and management of shared modules within the application. |
| packages/enhanced/src/lib/sharing/ProvideSharedPlugin.ts | The code changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  1. Added support for specifying and resolving module layers in the ConsumeSharedModule and ConsumeSharedPlugin classes. This includes introducing new properties like layer, issuerLayer, and requiredLayer to handle layer-specific requests and factorize modules based on the layer context.

  2. Updated the ProvideSharedPlugin class to handle layer-specific requests and create composite keys for module lookup based on the layer information. This allows for better management and resolution of shared modules across different layers.

  3. Added TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new layer-related properties.

  4. Updated the package.json file by adding a new Jest command to run specific test cases and bumping the webpack-cli dependency to version ^5.1.4.

The primary purpose of these changes is to enhance the module sharing capabilities in the enhanced package, particularly by introducing support for module layers. This will allow for more granular control and management of shared modules, enabling better isolation and flexibility in the application's architecture. |
| packages/enhanced/src/lib/sharing/SharePlugin.ts | Here is a short and concise technical summary of the changes:

The code changes introduce support for module layers in the ConsumeSharedModule and ConsumeSharedPlugin classes. This includes adding new properties like layer, issuerLayer, and requiredLayer to handle layer-specific module requests and factorize modules based on the layer context. Additionally, the package.json file was updated to include a new Jest command for testing the ConfigTestCases.basictest.js file, and TypeScript-based validation functions were added to ensure proper validation of the new properties in the ConsumeSharedPlugin schema. |
| packages/enhanced/src/lib/sharing/ShareRuntimeModule.ts | The code changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  1. Updated the ConsumeSharedModule and ConsumeSharedPlugin classes to support module layers, allowing for more granular control over module sharing and consumption. This includes adding new properties like layer, issuerLayer, and requiredLayer to handle layer-specific requests and module factorization.

  2. Added a new Jest command to the package.json file to run a specific test case for the ConfigTestCases.basictest.js file, along with an update to the webpack-cli dependency.

  3. Implemented TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new layer-related properties.

The overall purpose of these changes is to improve the module sharing capabilities within the enhanced package, providing more flexibility and control over how modules are shared and consumed, particularly when dealing with module layers. |
| packages/enhanced/src/lib/sharing/resolveMatchedConfigs.ts | The code changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  1. Updated the ConsumeSharedModule and ConsumeSharedPlugin to support module layers, allowing for more granular control over module sharing and resolution. This includes adding new properties like layer, issuerLayer, and requiredLayer to handle layer-specific requests and factorize modules based on the layer context.

  2. Added a new Jest command to the package.json file to run a specific test case for the ConfigTestCases.basictest.js file, and updated the webpack-cli dependency to version ^5.1.4.

  3. Implemented TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new layer-related properties.

The overall goal of these changes is to enhance the module sharing capabilities in the enhanced package, providing more flexibility and control over how modules are shared and consumed across different layers or contexts. |
| packages/enhanced/src/lib/sharing/utils.ts | The code changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  1. The ConsumeSharedModule and ConsumeSharedPlugin classes have been updated to support module layers, allowing for more granular control over how modules are shared and consumed. This includes adding new properties like layer, issuerLayer, and requiredLayer to the ConsumeOptions type and updating the corresponding logic in the classes.

  2. The package.json file has been updated to add a new Jest command for testing the ConfigTestCases.basictest.js file, and the webpack-cli dependency has been updated to version ^5.1.4.

  3. The ConsumeSharedPlugin schema validation has been enhanced with TypeScript-based validation functions to ensure proper validation of the new layer-related properties.

Overall, these changes aim to improve the module sharing capabilities in the enhanced package, particularly by introducing support for module layers and updating the related tooling and validation. |
| packages/enhanced/src/schemas/sharing/ConsumeSharedPlugin.check.ts | The changes in this file focus on enhancing the schema validation for the ConsumeSharedPlugin in the enhanced package. The key modifications are:

  1. Added support for validating new properties related to module layers, such as issuerLayer, requiredLayer, and layer. These properties are now checked for their existence and type (string) in the plugin options.
  2. Expanded the validation to ensure that the import, packageName, requiredVersion, shareKey, shareScope, and layer properties are properly defined and meet the expected criteria (e.g., non-empty string).
  3. Introduced additional checks to ensure that the eager and singleton properties are of the correct type (boolean).
  4. Factored out the validation logic into separate functions (r, e, t, n) to improve code organization and readability.

Overall, these changes aim to provide a more robust and comprehensive schema validation for the ConsumeSharedPlugin, ensuring that the plugin options are properly configured and meet the expected requirements. |
| packages/enhanced/src/schemas/sharing/ConsumeSharedPlugin.ts | The code changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  1. The ConsumeSharedModule and ConsumeSharedPlugin classes have been updated to support module layers, allowing for more granular control over how modules are consumed and shared. This includes the addition of new properties like layer, issuerLayer, and requiredLayer to handle layer-specific requests and module factorization.

  2. The package.json file has been updated to add a new Jest command for running a specific test case, and the webpack-cli dependency has been updated to version ^5.1.4.

  3. The schema validation for the ConsumeSharedPlugin has been improved by adding TypeScript-based validation functions to ensure proper validation of the new layer-related properties.

These changes aim to provide more flexibility and control over the module sharing functionality in the enhanced package, allowing for better support of layered module architectures. |
| packages/enhanced/src/schemas/sharing/ProviderSharedPlugin.check.ts | The code changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  1. Added support for specifying and resolving module layers in the ConsumeSharedModule and ConsumeSharedPlugin classes. This includes new properties like layer, issuerLayer, and requiredLayer to handle layer-specific requests and module factorization.

  2. Updated the package.json file by adding a new Jest command to run a specific test case and updating the webpack-cli dependency to version ^5.1.4.

  3. Implemented TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new layer-related properties.

The changes aim to enhance the module sharing functionality by introducing support for module layers, which allows for more granular control and management of shared modules within the application. |
| packages/enhanced/src/schemas/sharing/ProviderSharedPlugin.ts | The code changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  1. Updated the ConsumeSharedModule and ConsumeSharedPlugin classes to support module layers, adding new properties like layer, issuerLayer, and requiredLayer to handle layer-specific requests and factorize modules based on the layer context.

  2. Added a new Jest command to the package.json file to run a specific test case for the ConfigTestCases.basictest.js file, and updated the webpack-cli dependency to version ^5.1.4.

  3. Introduced TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new properties related to module layers. |
    | packages/enhanced/test/configCases/sharing/layers-consume-loader/src/index.js | The code changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  4. The ConsumeSharedModule and ConsumeSharedPlugin classes were updated to support module layers, allowing for more granular control over module sharing and resolution. This includes adding new properties like layer, issuerLayer, and requiredLayer to handle layer-specific requests.

  5. The package.json file was updated to add a new Jest command for testing the ConfigTestCases.basictest.js file, and the webpack-cli dependency was updated to version ^5.1.4.

  6. The ConsumeSharedPlugin schema validation was enhanced with TypeScript-based validation functions to ensure proper validation of the new layer-related properties.

These changes aim to improve the module sharing capabilities in the enhanced package, particularly by introducing support for module layers and enhancing the related configuration and testing. |
| packages/enhanced/test/configCases/sharing/layers-provides-loader/src/index.js | The changes in this file introduce several enhancements and fixes to the module sharing functionality in the enhanced package. The key modifications are:

  1. Added support for specifying and resolving module layers in the ConsumeSharedModule and ConsumeSharedPlugin classes, including new properties like layer, issuerLayer, and requiredLayer.
  2. Updated the ConsumeSharedPlugin class to handle layer-specific requests and factorize modules based on the layer context.
  3. Added a new Jest command to the package.json file to run a specific test case, and updated the webpack-cli dependency.
  4. Added TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new properties.

The primary purpose of these changes is to enhance the module sharing capabilities of the enhanced package, particularly by introducing support for module layers, which allows for more granular control and management of shared modules. |
| packages/enhanced/test/configCases/sharing/layers-share-plugin/src/index.js | The code changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  1. Updates to the ConsumeSharedModule and ConsumeSharedPlugin classes to support module layers, including the addition of new properties like layer, issuerLayer, and requiredLayer to handle layer-specific requests and module factorization.
  2. Addition of a new Jest command in the package.json file to run a specific test case for the ConfigTestCases.basictest.js file.
  3. Addition of TypeScript-based validation functions in the ConsumeSharedPlugin.check.ts file to ensure proper validation of the new properties introduced for module layer support.

The primary purpose of these changes is to extend the module sharing capabilities in the enhanced package by introducing support for module layers, allowing for more granular control and management of shared modules across different layers or contexts. |

Copy link
Contributor

@squadronai squadronai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incremental Review

Comments posted: 11

Configuration

Squadron Mode: essential

Commits Reviewed

e26d10712d98c450b9ae57babdfab27dee9e1dad...24ef6d05e48f9cb5f128479f515714e50028e780

Files Reviewed
  • packages/enhanced/src/declarations/plugins/sharing/ConsumeSharedPlugin.d.ts
  • packages/enhanced/src/declarations/plugins/sharing/SharePlugin.d.ts
  • packages/enhanced/src/lib/sharing/ConsumeSharedModule.ts
  • packages/enhanced/src/lib/sharing/ConsumeSharedPlugin.ts
  • packages/enhanced/src/lib/sharing/SharePlugin.ts
Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

  • package.json
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/.gitignore
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/async-boundary.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/index-test.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/index.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/layer-exporter.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/node_modules/react/index.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/node_modules/react/index2.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/package.json
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/test.config.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/webpack.config.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/.gitignore
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/loaders/different-layer-loader.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/loaders/explicit-layer-loader.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/loaders/react-layer-loader.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/node_modules/react/index.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/node_modules/react/index2.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/package.json
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/shared/react-boundary.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/test.config.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/tests/different-layers.test.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/tests/layer-inheritance.test.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/tests/unlayered-share.test.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/webpack.config.js
  • pnpm-lock.yaml

@module-federation module-federation deleted a comment from squadronai bot Nov 26, 2024
@module-federation module-federation deleted a comment from squadronai bot Nov 26, 2024
@module-federation module-federation deleted a comment from squadronai bot Nov 26, 2024
@ScriptedAlchemy ScriptedAlchemy changed the title feat(enhanced): support layers in consume share plugin feat(enhanced): support shared module layers Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants